Soothing Lantern: Polymer Edition #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Achieves this currently by just entirely removing the Soothing Lantern.
|
Looks good. I'll do a few tests later today to verify that there aren't any major bugs and resolve conflicts before merging. Thank you for your work! |
|
Awesome! Hopefully I didn't mess anything up! I may do some further PRs in future to improve the command structure, add some particle effects to the lantern, etc. This has been fun! |
HyperPigeon
reviewed
Nov 16, 2022
src/main/java/net/hyper_pigeon/eldritch_mobs/ability/active/offensive/GravityAbility.java
Outdated
Show resolved
Hide resolved
src/main/java/net/hyper_pigeon/eldritch_mobs/mixin/LivingEntityMixin.java
Outdated
Show resolved
Hide resolved
|
For the most part, everything looks great! I especially love the new look of the Soothing Lantern and I honestly think its' an improvement over the old texture. Just make the above changes and it should be good to merge. Once again, thank you for your hard work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the entire mod in its current state completely serverside-only!
The lantern is now also toggleable via a redstone signal (and requires one to be enabled... makes sense as a lantern IMO). I've tested the behaviour/functionality and it all seems to work!
I figured unless you were extremely attached to your original lantern design, this would serve the same purpose, but allow for use with vanilla clients.
There's also some code refactoring, including a solution that avoids the need to create an instance of each ability class 3 times over.
Thanks for your consideration!