-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new implementations for the search results service and the DAO and modify the existing implementations #1150
Conversation
Hi @mozzy11 , could you please review this PR? |
src/main/java/org/openelisglobal/sample/daoimpl/DatabaseSearchResultsDAO.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/sample/daoimpl/LuceneSearchResultsDAO.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/search/service/DatabaseSearchResultsService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/search/service/LuceneSearchResultsService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rahul6603 can you add one or two Integration tests for the SearchResultsService for Both DB and Lucene Implemenations and show that currently the DB implementation returns some results and the Lucene Implemenation returns no results
Issue - #1049
Summary
@Primary
annotations on DatabaseSearchResultsService and DatabaseSearchResultsDAO are temporary and will be moved to the new implementations once they are fully functional.CC: @mozzy11