Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new implementations for the search results service and the DAO and modify the existing implementations #1150

Merged
merged 10 commits into from
Jul 9, 2024

Conversation

rahul6603
Copy link
Contributor

Issue - #1049

Summary

  • We will create a new implementation of the SearchResultsService interface in the service layer, called LuceneSearchResultsService and a new implementation of the SearchResultsDAO interface, called LuceneSearchResultsDAO. Currently, these implementations contain placeholders for Apache Lucene search logic which will be added later.
  • We will modify the existing service layer implementation SearchResultsServiceImpl to DatabaseSearchResultsService and the existing DAO implementation SearchResultsDAOImp to DatabaseSearchResultsDAO.
  • The @Primary annotations on DatabaseSearchResultsService and DatabaseSearchResultsDAO are temporary and will be moved to the new implementations once they are fully functional.
  • Reference UML diagram

CC: @mozzy11

@rahul6603
Copy link
Contributor Author

Hi @mozzy11 , could you please review this PR?
Thank you.

Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahul6603 can you add one or two Integration tests for the SearchResultsService for Both DB and Lucene Implemenations and show that currently the DB implementation returns some results and the Lucene Implemenation returns no results

@rahul6603 rahul6603 requested a review from mozzy11 July 9, 2024 11:16
@mozzy11 mozzy11 merged commit 11d4faa into I-TECH-UW:develop Jul 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants