Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a first list of Tier 1 variables #57

Merged
merged 22 commits into from
Apr 16, 2024

Conversation

FlorianLeblancDr
Copy link
Contributor

I open a new pull-request with only Tier 1 variables.
I found it easier for @IAMconsortium/common-definitions-macro-economy to follow discussions and agree with PR with manageable size (working with small subset of variables and from the same tier).

Open to review for @IAMconsortium/common-definitions-macro-economy

@orichters thank for your work with #56 being usefull for the Tier 2 & 3 as well.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and questions inline. Please capitalize all variables and also the first word in the description.

definitions/variable/macro-economy/gdp.yaml Outdated Show resolved Hide resolved
definitions/variable/macro-economy/gdp.yaml Outdated Show resolved Hide resolved
definitions/variable/macro-economy/gdp.yaml Outdated Show resolved Hide resolved
definitions/variable/macro-economy/tag_econ_sectors.yaml Outdated Show resolved Hide resolved
@FlorianLeblancDr
Copy link
Contributor Author

FlorianLeblancDr commented Feb 26, 2024

Seems good to be merged @danielhuppmann

Copy link
Contributor Author

@FlorianLeblancDr FlorianLeblancDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for GDP and population ok

@FlorianLeblancDr FlorianLeblancDr self-assigned this Feb 28, 2024
use tag consistently for tiers
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @IAMconsortium/common-definitions-macro-economy for putting together this PR.

Two suggestions before merging, to ensure the long-term viability of the common-definitions variable template: this PR adds quite a few top-level variables (or categories). In order to keep the number of top-level variables small, how about the following:

  1. make Employment and Unemployment sub-categories of Population (similar to Population|Urban vs. Population|Rural).

  2. make Import and Export sub-categories of Trade and add [Value] for disambiguation, so have

    • Trade|Import [Value]
    • Tade|Export [Value]

    and then later add

    • Trade|Primary Energy|Biomass [Volume]
    • ..

@FlorianLeblancDr
Copy link
Contributor Author

FlorianLeblancDr commented Mar 4, 2024

Thank you Daniel for reviewing this.

Thank you @IAMconsortium/common-definitions-macro-economy for putting together this PR.

Two suggestions before merging, to ensure the long-term viability of the common-definitions variable template: this PR adds quite a few top-level variables (or categories). In order to keep the number of top-level variables small, how about the following:

1. make Employment and Unemployment sub-categories of Population (similar to Population|Urban vs. Population|Rural).

I am ok with this. Even though Employment + Unemployment does not equal total population, but this is a matter of appropriate definition. Olivier and Laurent, if you agree I will push the changes.

2. make Import and Export sub-categories of Trade and add `[Value]` for disambiguation, so have
   
   * Trade|Import [Value]
   * Trade|Export [Value]
   
   and then later add
   
   * Trade|Primary Energy|Biomass [Volume]
   * ..

This is a good idea.
I am less sure about this one as I was going to suggest a GDP decomposition as tier 2 variables : Export and Import in values being component of GDP decomposition.
But in this case this would be :
GDP|"Production side" of something else|Export

I will think about it. Or we can apply your suggestion and revert it in an upcoming PR.

This is something we can discuss during a zoom meeting within the sub-group.

@danielhuppmann
Copy link
Member

@FlorianLeblancDr, you mentioned that you will have a Zoom meeting in the sub-group - did you already have a chance to discuss this further?

@FlorianLeblancDr
Copy link
Contributor Author

Thanks @danielhuppmann for the reminder.
The zoom was a suggestion but we did not plan it.

I will commit a change for Employment and follow your suggestion Trade, which will help to close the PR faster.

Then leave a discussion on GDP composition for later.

@danielhuppmann
Copy link
Member

Thanks @FlorianLeblancDr. Agree on your point about population and employment being not quite ideal. How about “Labour Market|Employment” as a new top-level category?

@danielhuppmann
Copy link
Member

ping @FlorianLeblancDr - can we move this forward and merge soon?

@FlorianLeblancDr
Copy link
Contributor Author

@danielhuppmann
Yes sorry I got busy.

This seems good now :

  • I took your suggestion for Export / Import
  • I find a way to implement Employment variables as a sub-category of Population.
    This makes sens, in a near future we might want to report unemployment by education type (and by sector / education)

@danielhuppmann
Copy link
Member

Thank you!

I'm not sure whether this list is helpful...

  • Population|Employment
  • Population|Female
  • Population|Male
  • Population|Not Active
  • Population|Unemployment
  • Population|Urban
  • Population|Rural

There are too many different categories mixed together...

Can I again suggest to use Labour Force|Employed vs. Labour Force|Unemployed (plus breakdowns by education later) instead?

@FlorianLeblancDr
Copy link
Contributor Author

Sure, I am kind of agnostic at this point, I was trying to follow your initial suggestion to move it in Population.
I got your point : Population defines what people are (by age, sex, education) not what they do.

I find it useful to have the "Not Active" in the tag, in order to suggest, besides definitions, that the sum of Employment + Unemployment is not equal to total population.. even though "Labor Force|Not Active" is a little strange.
"Pop. Activity" could include all.

Feel free to follow your intuition and merge.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as is and will revise the Labour-Force variables in a follow-up PR.

@danielhuppmann danielhuppmann merged commit 86b357e into IAMconsortium:main Apr 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants