pass custom factory in copy constructor #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Marshall <[email protected]>
JMConnect
force-pushed
the
ssl_passthrough
branch
from
9bc5dc2 to
a822c6f
Compare
|
Thanks, @JMConnect ! Code looks pretty safe. Will aim to get it merged soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the patch I referenced here: #200 (comment)
Our code uses connections/pooling based on AS400 objects and not properties. Ultimately it goes through AS400JDBCDataSource.getConnection, which uses a copy of the AS400 object for the connection. The AS400 copy constructor in turn uses the SSLOptions copy constructor. This just adds the new property to the copy constructor with the others, which then carries through and custom SSL properties work for SQL connections.