Support for crtsqlcppi and additional compile options #202
Conversation
| @@ -231,6 +246,13 @@ SQLCIMOD_SYSIFCOPT := $(CMOD_SYSIFCOPT) | |||
| SQLCIMOD_TERASPACE := *YES *TSIFC | |||
| SQLCIMOD_TGTRLS := $(TGTRLS) | |||
|
|
|||
| SQLCPPIMOD_DBGVIEW := *SOURCE | |||
There was a problem hiding this comment.
maybe this should not be hardcoded
There was a problem hiding this comment.
please commit a change to this in this branch/pull request
src/mk/def_rules.mk
Outdated
| CURLIB := | ||
| DBGVIEW := *ALL | ||
| DBGVIEW := |
There was a problem hiding this comment.
do we need to change the default?
There was a problem hiding this comment.
For debug view, it makes sense to NOT change the previous behavior. But I am interested in a way to built an entire project either for debug or optimized without needed to override that option at an object level.
There was a problem hiding this comment.
Please update this in another commit and open an issue or discussion on how to have the same Rules.mk work for both debug and optimized
There was a problem hiding this comment.
Done: Project level flag to build an entire project for a target debug level. #203
src/mk/def_rules.mk
Outdated
| @$(PRESETUP) \ | ||
| $(SCRIPTSPATH)/launch "$(JOBLOGFILE)" "$(crtcmd)" >> $(LOGFILE) 2>&1 && $(call logSuccess,$@) || $(call logFail,$@) | ||
| @($(call EVFEVENT_DOWNLOAD,$(basename $(@F)).evfevent); ret=$$?; rm $(DEPDIR)/$*.Td 2>/dev/null; rm "$<-1252" 2>/dev/null; exit $$ret) | ||
| @rm "$<-1252" |
There was a problem hiding this comment.
I see this file being deleted twice. What is this file for?
So does this work. I.e. the CPP front end is not a PASE executable that is called from an ILE command
There was a problem hiding this comment.
Ah, it should only be deleted once. Good catch. As for the file, I replicated code from the CRTSQLCI path that (I presume) fixed a problem dealing with CCSID and the SQL precompiler. Perhaps this is code that should be revisited? Here is the comment from the code that I replicated: # Temp: Convert UTF-8 to temporary Windows Latin-1, because SQLC pre-compiler doesn't understand UTF-8
There was a problem hiding this comment.
Right, the proper solution is to specify TGTCCSID on the compiler so that it converts to a target EBCDIC CCSID before compiling.
This is supported by RPGLE, CLLE, and CBLLE
But I don't know if CRTSQLCI supports it
1252 might not work for all languages, seems fragile to me
There was a problem hiding this comment.
It looks like CRTSQLCI and CRTSQLCPPI both have this parm : Conversion CCSID (CVTCCSID) - Help
The CCSID used for conversion when a UTF-8 source stream
file is provided on the Source stream file (SRCSTMF)
parameter. Otherwise, this parameter is ignored.
There was a problem hiding this comment.
This is how RPG solves it https://www.ibm.com/support/pages/compile-rpg-unicode-source-new-tgtccsid-parameter-71-72-73
There was a problem hiding this comment.
Yes CVTCCSID is perfect
SO the value is derived from .ibmi.json
and is stored in TGTCCSID variable
|
Bob-recursive compiles cleanly for me |
No description provided.