Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kind Specific Strict Versioning #155

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

HonakerM
Copy link
Collaborator

Related Issue

Supports #?

Related PRs

This PR is not dependent on any other PR

What this PR does / why we need it

This PR allows end-users to selectively apply strict versioning based on the kind. This is specifically for unversioned resources like TemporaryPatches

Special notes for your reviewer

If applicable**

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

What gif most accurately describes how I feel towards this PR?

Example of a gif

@HonakerM HonakerM requested a review from gabe-l-hart as a code owner January 23, 2025 15:41
Signed-off-by: Michael Honaker <[email protected]>
@HonakerM HonakerM force-pushed the optional_strict_versioning branch from 4631545 to b20e17b Compare January 23, 2025 15:42
@HonakerM
Copy link
Collaborator Author

Hey @gabe-l-hart I thought the strict_versioning_regex was the simplest way to add this "optional strict versioning" feature. I also had the idea for adding a parameter to the @controller decorator but that fell worse. Please LMK if you have any thoughts

Copy link
Collaborator

@gabe-l-hart gabe-l-hart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Nice and simple

@HonakerM HonakerM merged commit 27e9d94 into IBM:main Jan 24, 2025
6 checks passed
@HonakerM HonakerM mentioned this pull request Jan 29, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants