-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text2sql execution accuracy metric updates #1604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oktie Hassanzadeh <[email protected]>
dd76590
to
7e905b6
Compare
Signed-off-by: Oktie Hassanzadeh <[email protected]>
Signed-off-by: Oktie Hassanzadeh <[email protected]>
Signed-off-by: Oktie Hassanzadeh <[email protected]>
Signed-off-by: Oktie Hassanzadeh <[email protected]>
I also added non-execution accuracy metrics, that measure the validity and equivalence of the SQLs without running them. Example output from
|
Signed-off-by: Oktie Hassanzadeh <[email protected]>
Signed-off-by: Oktie Hassanzadeh <[email protected]>
Signed-off-by: Oktie Hassanzadeh <[email protected]>
Signed-off-by: Oktie Hassanzadeh <[email protected]>
Signed-off-by: Oktie Hassanzadeh <[email protected]>
Signed-off-by: Oktie Hassanzadeh <[email protected]>
Signed-off-by: Oktie Hassanzadeh <[email protected]>
Signed-off-by: Oktie Hassanzadeh <[email protected]>
Signed-off-by: Yotam Perlitz <[email protected]>
perlitz
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @oktie for this!
…scores Signed-off-by: Yotam Perlitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to add additional metrics and results to the output of the text2sql execution accuracy metric implementation. We used to produce just one number:
1
if the dataframe produced by the SQLs in pred and gold are the same,0
otherwise. I've added scores to report 12 scores/outputs:What we used to get (output of
examples/evaluate_text2sql.py
):What we get with the new additions: