-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive on Accessible name #2122
Comments
See Slack thread at |
As reported by Nikhil Tomar:
|
Also see companion issue in Carbon with details at: carbon-design-system/carbon#18204 |
@shunguoy The original violation is correctly not longer triggering. However, I'm seeing a couple "Needs Review" issues that should not trigger on this Carbon AI page DOM:
Triggered byRule ID: input_label_visible[file not changed in the PR #2170 ]
I can open a new issue or send this back to be fixed? |
Phill added 2.5.3 to the Help file for Rule ID: input_label_visible
|
…deprecate aria_search_label_unique rule (#2170) * update the rule logic and add new test cases #2122 * update act mapping #dev-2122-new * add 2.5.3 to `input_label_visible` help Help and requirements that are reported should match. Rule reports to both 3.3.2 & 2.5.3, but Help did not. --------- Co-authored-by: Phill Jenkins <[email protected]> Co-authored-by: Tom Brunet <[email protected]>
…deprecate aria_search_label_unique rule V4 (#2178) * Bump path-to-regexp and express in /rule-server (#2128) Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together. Updates `path-to-regexp` from 0.1.10 to 0.1.12 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12) Updates `express` from 4.21.0 to 4.21.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md) - [Commits](expressjs/express@4.21.0...4.21.2) --- updated-dependencies: - dependency-name: path-to-regexp dependency-type: indirect - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tom Brunet <[email protected]> * fix dark mode react portal pop-up (#2138) * fix(extension):Fix reset filter link #1877 (#2136) * reset filter fix * css fix --------- Co-authored-by: Tom Brunet <[email protected]> * fix(extension): Don't show full data:text/html content on generated HTML report page (#2140) * truncating url * remove unused import * Adjust tooltip location --------- Co-authored-by: Tom Brunet <[email protected]> * chore(extension): carbon package update and use new carbon combobutton #1842 (#2137) * carbon package update and use new carbon combobutton * alignment fix --------- Co-authored-by: Tom Brunet <[email protected]> * update the rule logic and add new test cases #2122 * update act mapping #dev-2122-new --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tom Brunet <[email protected]> Co-authored-by: Namrata Singh <[email protected]>
…deprecate aria_search_label_unique rule (IBMa#2170) * update the rule logic and add new test cases IBMa#2122 * update act mapping #dev-2122-new * add 2.5.3 to `input_label_visible` help Help and requirements that are reported should match. Rule reports to both 3.3.2 & 2.5.3, but Help did not. --------- Co-authored-by: Phill Jenkins <[email protected]> Co-authored-by: Tom Brunet <[email protected]>
I see a violation "Accessible name does not match or contain the visible label text" with the latest rule set (the violation is only seen on 06-Aug-2024 deployment and later versions) on carbon's AILabel component
Visually, the button displays two with content " AI" and "Text goes here"
The aria-label on button is set to "AI Text goes here" (with a space b/w "AI" and Text goes here" )
more details are here : carbon-design-system/carbon#18204
see more details: https://ibm-studios.slack.com/archives/C036P1CTN/p1733731510915439
The text was updated successfully, but these errors were encountered: