Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive on Accessible name #2122

Closed
shunguoy opened this issue Dec 9, 2024 · 5 comments · Fixed by #2170 or #2178
Closed

False positive on Accessible name #2122

shunguoy opened this issue Dec 9, 2024 · 5 comments · Fixed by #2170 or #2178
Assignees
Labels
Bug Something isn't working engine Issues in the accessibility-checker-engine component false-positive Rules incorrectly reporting a violation T64 user-reported Issues identified outside of the core team

Comments

@shunguoy
Copy link
Contributor

shunguoy commented Dec 9, 2024

I see a violation "Accessible name does not match or contain the visible label text" with the latest rule set (the violation is only seen on 06-Aug-2024 deployment and later versions) on carbon's AILabel component
Visually, the button displays two with content " AI" and "Text goes here"
The aria-label on button is set to "AI Text goes here" (with a space b/w "AI" and Text goes here" )
more details are here : carbon-design-system/carbon#18204

<button
  aria-expanded="false"
  aria-controls="id-:re:"
  aria-label="AI Text goes here"
  type="button">
    <span class="cds--ai-label__text">AI</span>
    <span class="cds--ai-label__additional-text">Text goes here</span>
</button>

see more details: https://ibm-studios.slack.com/archives/C036P1CTN/p1733731510915439

@shunguoy shunguoy added engine Issues in the accessibility-checker-engine component T64 labels Dec 9, 2024
@philljenkins
Copy link
Contributor

@philljenkins
Copy link
Contributor

philljenkins commented Dec 10, 2024

As reported by Nikhil Tomar:
[email protected], Frontend Dev, Carbon

This is the "reproducible test" environment

@MHoov MHoov added the user-reported Issues identified outside of the core team label Dec 10, 2024
@philljenkins
Copy link
Contributor

Also see companion issue in Carbon with details at: carbon-design-system/carbon#18204

@philljenkins
Copy link
Contributor

@shunguoy The original violation is correctly not longer triggering.

However, I'm seeing a couple "Needs Review" issues that should not trigger on this Carbon AI page
AILabel component

DOM:

<button 
   aria-expanded="false" aria-controls="id-:r4m:" aria-label="AI Show information" 
   type="button" 
   class="cds--toggletip-button cds--ai-label__button cds--ai-label__button--mini cds--ai-label__button--default">
      <span class="cds--ai-label__text">AI</span>
</button>
  1. The text "AI" is correctly part of the button and is displayed.
  2. A single Checker rule input_label_visible is incorrectly reporting against two requirements (SCs). It seem that the single potential reason is triggered, but reported twice. I think neither should be reported:
    • 2.5.3 Label in Name: Needs review: The input element does not have an associated visible label
    • 3.3.2 Labels or Instructions: Needs review: The input element does not have an associated visible label

Image

Triggered by

Rule ID: input_label_visible[file not changed in the PR #2170 ]
Reason ID: potential_no_label

  • while the rule reports against both, the Help is 3.3.2 only
rulesets: [{
        "id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
        "num": ["2.5.3", "3.3.2"], //map to both requirements in help
        "level": eRulePolicy.VIOLATION,
        "toolkitLevel": eToolkitLevel.LEVEL_ONE

Image

I can open a new issue or send this back to be fixed?

@philljenkins
Copy link
Contributor

Phill added 2.5.3 to the Help file for Rule ID: input_label_visible

About this requirement

IBM 2.5.3 Label in Nane

@MHoov MHoov added the false-positive Rules incorrectly reporting a violation label Feb 3, 2025
tombrunet added a commit that referenced this issue Feb 4, 2025
…deprecate aria_search_label_unique rule (#2170)

* update the rule logic and add new test cases #2122

* update act mapping #dev-2122-new

* add 2.5.3 to `input_label_visible` help

Help and requirements that are reported should match.
Rule reports to both 3.3.2 & 2.5.3, but Help did not.

---------

Co-authored-by: Phill Jenkins <[email protected]>
Co-authored-by: Tom Brunet <[email protected]>
tombrunet added a commit that referenced this issue Feb 4, 2025
…deprecate aria_search_label_unique rule V4 (#2178)

* Bump path-to-regexp and express in /rule-server (#2128)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.0 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.0...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* fix dark mode react portal pop-up (#2138)

* fix(extension):Fix reset filter link #1877 (#2136)

* reset filter fix

* css fix

---------

Co-authored-by: Tom Brunet <[email protected]>

* fix(extension): Don't show full data:text/html content on generated HTML report page  (#2140)

* truncating url

* remove unused import

* Adjust tooltip location

---------

Co-authored-by: Tom Brunet <[email protected]>

* chore(extension): carbon package update and use new carbon combobutton #1842 (#2137)

* carbon package update and use new carbon combobutton

* alignment fix

---------

Co-authored-by: Tom Brunet <[email protected]>

* update the rule logic and add new test cases #2122

* update act mapping #dev-2122-new

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>
Co-authored-by: Namrata Singh <[email protected]>
evannaderi pushed a commit to evannaderi/ace-engine that referenced this issue Feb 5, 2025
…deprecate aria_search_label_unique rule (IBMa#2170)

* update the rule logic and add new test cases IBMa#2122

* update act mapping #dev-2122-new

* add 2.5.3 to `input_label_visible` help

Help and requirements that are reported should match.
Rule reports to both 3.3.2 & 2.5.3, but Help did not.

---------

Co-authored-by: Phill Jenkins <[email protected]>
Co-authored-by: Tom Brunet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working engine Issues in the accessibility-checker-engine component false-positive Rules incorrectly reporting a violation T64 user-reported Issues identified outside of the core team
Projects
None yet
3 participants