fix(engine): Fix issues related to accessible name concatenation and deprecate aria_search_label_unique rule #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 28, 2025
Closed
This was referenced Feb 3, 2025
Help and requirements that are reported should match. Rule reports to both 3.3.2 & 2.5.3, but Help did not.
tombrunet
approved these changes
Feb 4, 2025
evannaderi
pushed a commit
to evannaderi/ace-engine
that referenced
this pull request
Feb 5, 2025
…deprecate aria_search_label_unique rule (IBMa#2170) * update the rule logic and add new test cases IBMa#2122 * update act mapping #dev-2122-new * add 2.5.3 to `input_label_visible` help Help and requirements that are reported should match. Rule reports to both 3.3.2 & 2.5.3, but Help did not. --------- Co-authored-by: Phill Jenkins <[email protected]> Co-authored-by: Tom Brunet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
Testing reference:
test/v2/checker/accessibility/rules/label_name_visible_ruleunit/button-label-pass.html
test/v2/checker/accessibility/rules/label_name_visible_ruleunit/button-label-pass2.html
The above test cases trigger an "Accessible name does not match or contain the visible label text".
After the fix, the error should disappear.
I have conducted the following for this PR:
Assets to aide review attached
Definition of Done