Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(node): ESM packages need .js extension for modules #2169

Merged
merged 5 commits into from
Feb 4, 2025
Merged

bug(node): ESM packages need .js extension for modules #2169

merged 5 commits into from
Feb 4, 2025

Conversation

tombrunet
Copy link
Member

@tombrunet tombrunet commented Jan 24, 2025 •
edited
Loading

  • Automated tool bug

This PR is related to the following issue(s):

Fail due to missing .js extensions when using ESM

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@tombrunet tombrunet marked this pull request as ready for review January 27, 2025 15:06
@tombrunet tombrunet marked this pull request as draft January 27, 2025 15:07
@shunguoy shunguoy added the T64 label Jan 27, 2025
@tombrunet tombrunet marked this pull request as ready for review January 27, 2025 20:28
@tombrunet tombrunet requested a review from shunguoy January 28, 2025 21:18
shunguoy
shunguoy previously approved these changes Jan 29, 2025
View reviewed changes
@tombrunet tombrunet self-assigned this Jan 29, 2025
@tombrunet tombrunet mentioned this pull request Feb 4, 2025
Merged
@philljenkins philljenkins merged commit a7e92a1 into master Feb 4, 2025
17 checks passed
@philljenkins philljenkins deleted the mjs-js-ext branch February 4, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philljenkins philljenkins philljenkins approved these changes

@shunguoy shunguoy shunguoy left review comments

Assignees

@tombrunet tombrunet

Labels
T64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tombrunet @philljenkins @shunguoy