Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Add note of [not approved] in ACT Text Results debug file #2172

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

tombrunet
Copy link
Member

@tombrunet tombrunet commented Jan 27, 2025

  • New Rule(s): List rule IDs
  • New or modified help files: List rule IDs
  • Rule bug: List rule IDs
  • Extension UI bug
  • Automated tool bug
  • Other (Provide information)

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other Action Artifacts

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@philljenkins philljenkins self-assigned this Feb 4, 2025
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'not approved' showing up great in ACT Text Results

@philljenkins philljenkins changed the title chore(repo): Add note of unapproved in ACT txt debug result chore(repo): Add note of [not approved] in ACT Text Results debug file Feb 4, 2025
@tombrunet tombrunet merged commit 1b7339c into master Feb 4, 2025
17 checks passed
@tombrunet tombrunet deleted the act-unapproved branch February 4, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants