Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ACT): ACT errors with scIds for ARIA and HTML #2193

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

tombrunet
Copy link
Member

  • Other (Provide information)

ACT reported that some of our reports included []. This was due to ARIA and HTML criteria not having an SC to report against. These are filtered out in this PR.

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing [] to "" makes sense

@tombrunet tombrunet merged commit 8329365 into master Feb 10, 2025
17 checks passed
tombrunet added a commit that referenced this pull request Feb 10, 2025
* update the rule and add a test case #dev-2085 (#2180)

Co-authored-by: Phill Jenkins <[email protected]>

* fix(cypress-accessibility-checker) update links in ReadMe (#2188)

* fix URL

* fix all 404 links

---------

Co-authored-by: Tom Brunet <[email protected]>

* ACT errors with scIds (#2193)

* Generate summaries on close (#2196)

* chore(archive): Create archive for Feb 10, 2025

---------

Co-authored-by: Phill Jenkins <[email protected]>
Co-authored-by: Shunguo Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants