Skip to content

Commit

Permalink
Require PHP 8.4+
Browse files Browse the repository at this point in the history
  • Loading branch information
olvlvl committed Nov 29, 2024
1 parent 0489a41 commit 86a6303
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 42 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/code-style.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
uses: shivammathur/setup-php@v2
with:
coverage: none
php-version: "8.2"
php-version: "8.4"
ini-values: memory_limit=-1
tools: phpcs, cs2pr
- name: Run PHP Code Sniffer
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Install PHP
uses: shivammathur/setup-php@v2
with:
php-version: "8.2"
php-version: "8.4"
ini-values: memory_limit=-1
tools: composer:v2
- name: Cache dependencies
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ jobs:
strategy:
matrix:
php-version:
- "8.2"
- "8.3"
- "8.4"
steps:
- name: Checkout
Expand Down Expand Up @@ -41,7 +39,7 @@ jobs:
run: make test-coveralls

- name: Upload code coverage
if: ${{ matrix.php-version == '8.2' }}
if: ${{ matrix.php-version == '8.4' }}
env:
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG PHP_VERSION=8.2
ARG PHP_VERSION=8.4
FROM php:${PHP_VERSION}-cli-bookworm

RUN <<-EOF
Expand Down
12 changes: 1 addition & 11 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,7 @@ test-cleanup:
@rm -rf tests/sandbox/*

.PHONY: test-container
test-container: test-container-82

.PHONY: test-container-82
test-container-82:
@-docker compose run --rm app82 bash
@docker compose down -v

.PHONY: test-container-83
test-container-83:
@-docker compose run --rm app83 bash
@docker compose down -v
test-container: test-container-84

.PHONY: test-container-84
test-container-84:
Expand Down
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "icanboogie/bind-symfony-dependency-injection",
"type": "library",
"version": "6.0",
"version": "7.0",
"description": "Binds symfony/dependency-injection to ICanBoogie",
"keywords": [
"dependency",
Expand Down Expand Up @@ -30,8 +30,8 @@
"minimum-stability": "dev",
"prefer-stable": true,
"require": {
"php": ">=8.2",
"icanboogie/icanboogie": "^6.0",
"php": ">=8.4",
"icanboogie/icanboogie": "^7.0",
"olvlvl/symfony-dependency-injection-proxy": "^6.0",
"symfony/config": "^7.0",
"symfony/yaml": "^7.0"
Expand Down
22 changes: 0 additions & 22 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
@@ -1,27 +1,5 @@
---
services:
app82:
build:
context: .
args:
PHP_VERSION: "8.2"
environment:
PHP_IDE_CONFIG: 'serverName=icanboogie-bind-symfony-dependency-injection'
volumes:
- .:/app:delegated
- ~/.composer:/root/.composer:delegated
working_dir: /app
app83:
build:
context: .
args:
PHP_VERSION: "8.3"
environment:
PHP_IDE_CONFIG: 'serverName=icanboogie-bind-symfony-dependency-injection'
volumes:
- .:/app:delegated
- ~/.composer:/root/.composer:delegated
working_dir: /app
app84:
build:
context: .
Expand Down

0 comments on commit 86a6303

Please sign in to comment.