Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Team page #149

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Team page #149

wants to merge 46 commits into from

Conversation

yukitya-1811
Copy link
Contributor

Description

Add Team Page

  • Adding a team page to display faculty advisors, core members and executive members of all SIGs (including CompSoc, Diode, Piston and ExeCom)
  • Adding Core and Faculty model in accounts/models.py

(Closed PR for reference - #134)
(Closed PR for reference - #141)
Fixes #139

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

yukitya-1811 and others added 30 commits May 8, 2024 23:52
@yukitya-1811
Added tab component and styled it appropriately
1b74e6e
@yukitya-1811
Basic HTML for Team Page done
8444015
@yukitya-1811
Added profile_picture to ExecutiveMember model
86d134d
@yukitya-1811
Finalized HTML for Faculty and Member separation on each sig tab
b63753e
@yukitya-1811
Finished section separation within each sig tab for Faculty, Core and…
21f06b0 
… Members. Also added proper sequential loading of Core Members
@yukitya-1811
Added logic to fetch coremember pfp from execmember
1cbbfcb
@yukitya-1811
Fixed light mode colours
393a8b2
@yukitya-1811
Finished layout for member cards and buttons
2b2c602
@yukitya-1811
Fixed minor issue (Piston members being loaded in Diode members section)
2448232
@yukitya-1811
Formatted code for better readability
1f25a8d
@yukitya-1811
Fixed centering of tablist issue (Finally)
0957689
@yukitya-1811
Added links to all Github and Linkedin buttons
0f96a94
@yukitya-1811
Added proper verbose_name_plural for Faculty
f3d8796
@yukitya-1811
After pre commit hooks
e540e5e
@yukitya-1811
Revert "Added links to all Github and Linkedin buttons"
ec7265c 
This reverts commit 4cd43dd.
@yukitya-1811
Resolving conflicts #1
d831b7f
@yukitya-1811
Add Team link to small navbar
301a96d
@yukitya-1811
DB fix commit
7764e60
@yukitya-1811
Made pre-commit changes
2394e7e
@yukitya-1811
Added default pfp png
b44baa4
@yukitya-1811
Made requested changes
f1debe5
@yukitya-1811
Finished faculty website buttons
5b05494
@yukitya-1811
Added checks for links belonging to Faculty model
c7bb70a
@yukitya-1811
Cleaned up migrations
110917f
@yukitya-1811 @nishant-nayak
Changed upload folder for profile pictures to accounts/executivemember
6d446bd 
Co-authored-by: Nishant Nayak <[email protected]>
@yukitya-1811 @nishant-nayak
Update corpus/pages/urls.py
1639e76 
Co-authored-by: Nishant Nayak <[email protected]>
@yukitya-1811
Revert "Added checks for links belonging to Faculty model"
bbd88ca 
This reverts commit 61aba1f.
@yukitya-1811
Revert "Fixed conflicts"
a00ee2c 
This reverts commit 829451d, reversing
changes made to 61aba1f.
@yukitya-1811
Fixed html issues and query logic
98c6858
@yukitya-1811
Fixed html indentation and member fetching query to exclude faculty u…
8ef8c1b 
…sers
@render Render
Copy link

render bot commented May 8, 2024

Your Render PR Server URL is https://corpus-dev-pr-149.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cotsbsgl6cac73cj0rng.

anirudhprabhakaran3
anirudhprabhakaran3 requested changes May 9, 2024
View reviewed changes
corpus/accounts/migrations/0004_alter_executivemember_date_joined.py Outdated Show resolved Hide resolved
corpus/accounts/migrations/0005_alter_executivemember_date_joined_and_more.py Outdated Show resolved Hide resolved
corpus/accounts/models.py Outdated Show resolved Hide resolved
corpus/accounts/models.py Outdated Show resolved Hide resolved
corpus/accounts/models.py Outdated Show resolved Hide resolved
corpus/impulse/views.py Outdated Show resolved Hide resolved
corpus/pages/views.py Outdated Show resolved Hide resolved
corpus/pages/views.py Outdated Show resolved Hide resolved
corpus/pages/views.py Outdated Show resolved Hide resolved
corpus/pages/views.py Outdated Show resolved Hide resolved
@anirudhprabhakaran3
Copy link
Member

I think we'll have to sit and rewrite the team page view function to make sure we cover all edge cases and stuff.

@nishant-nayak nishant-nayak self-requested a review May 27, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-nayak nishant-nayak Awaiting requested review from nishant-nayak

@anirudhprabhakaran3 anirudhprabhakaran3 Awaiting requested review from anirudhprabhakaran3

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yukitya-1811 @anirudhprabhakaran3 @nishant-nayak