DSERV-635-dey-predictions #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengchd
reviewed
Feb 6, 2025
There was a problem hiding this comment.
the adapter looks good, will need changes on other files:
- put an example data file under data/samples
- add the adapter to LABEL_TO_ADAPTER in active_adapters.py
- update schema-config.yaml (mainly the properties part)
- update data_sources.yaml (can wait until the data is in portal)
@pedrohr can you also take a look to see if I'm missing anything? I suppose we are still keeping schema-config.yaml. There's already a 'variant to phenotype' entry there for GWAS data with different properties, should we add a new entry for 'variant to phenotype V2F' then?
ian-whaling
force-pushed
the
DSERV-635-dey-predictions
branch
from
d3381d2 to
794aa31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.