Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created automatic pull request template #85

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

disvid
Copy link
Collaborator

@disvid disvid commented Dec 29, 2024

Related Issue

Closes #79 & #86

Type of Change

Put x inside the square bracket to specify what type of change your PR is:

  • New Feature
  • Bug Fix
  • Code Refactor
  • Documentation Update
  • Other (please specify):

Description of Change

Added automatic ISSUE and PR TEMPLATE, so that its easy for contributors to create a new pull request/issue.

Implementation Details

Required files/folders have been added in .github folder.

@AyushDharDubey
Copy link
Collaborator

Hi @disvid,

please make sure that your PR aligns with our community guidelines.
kindly update your PR description by tonight at 2359 hours or label it as draft. If the updates aren't made by then, we may need to proceed with closing this one.

@disvid
Copy link
Collaborator Author

disvid commented Dec 30, 2024

@AyushDharDubey done sir, i request you to kindly assign me issue #20 & #49

@AyushDharDubey
Copy link
Collaborator

i feel following section in your issue template is redundant, it is already covered via github

name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

@disvid
Copy link
Collaborator Author

disvid commented Dec 30, 2024

@AyushDharDubey It is not redundant, please check the docs. It won't work without -

name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

@AyushDharDubey
Copy link
Collaborator

@AyushDharDubey It is not redundant, please check the docs. It won't work without -

may you please quote the specific page

@disvid
Copy link
Collaborator Author

disvid commented Dec 30, 2024

@AyushDharDubey It is not redundant, please check the docs. It won't work without -

may you please quote the specific page

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository @AyushDharDubey here you go sir.

@AyushDharDubey
Copy link
Collaborator

To automatically set a default issue title, assign the issue to people with read access to the repository, or apply labels to issues raised from the template, use the fields under "Optional additional information." You can also add these details in the issue template with title, labels, or assignees in a YAML frontmatter format.

i assume

name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

refers to the "Optional additional information" section. let me know if you believe otherwise.

@disvid
Copy link
Collaborator Author

disvid commented Dec 30, 2024

@AyushDharDubey I think we can remove:

title: ''
labels: ''
assignees: ''

name: and about: will be helpful and needed
Screenshot from 2024-12-31 00-35-54

i have made the changes.

@AyushDharDubey
Copy link
Collaborator

okay, if you insist.
i was just concerned about the assignee's section because, in our event, no issue will be assigned at the time of creation. this makes the field absolutely useless, it will always remain blank and will have to be updated manually later once the issue is assigned.

@AyushDharDubey
Copy link
Collaborator

the rest looks great
i am proceeding to merge the PR now

@disvid
Copy link
Collaborator Author

disvid commented Dec 30, 2024

yes sir i have removed the assignee's section

@AyushDharDubey AyushDharDubey merged commit 49af5be into IMGIITRoorkee:master Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Automatic PR template
2 participants