Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verified case #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Verified case #14

wants to merge 3 commits into from

Conversation

Prernaswarna
Copy link
Member

No description provided.

@Prernaswarna Prernaswarna requested a review from nisarg73 October 14, 2020 14:11
nisarg73
nisarg73 requested changes Oct 14, 2020
View reviewed changes
src/components/genericFormMaker.js Outdated Show resolved Hide resolved
src/components/genericFormMaker.js Outdated Show resolved Hide resolved
src/components/genericFormMaker.js Outdated Show resolved Hide resolved
src/components/genericFormMaker.js Outdated Show resolved Hide resolved
src/components/input_fields/editUpload.js Outdated Show resolved Hide resolved
src/components/input_fields/fileField.js Outdated Show resolved Hide resolved
src/components/profile/profileForm.js Outdated Show resolved Hide resolved
src/components/profile/profile.js Show resolved Hide resolved
src/components/profile/profileForm.js Outdated Show resolved Hide resolved
src/constants/input.js Outdated Show resolved Hide resolved
@nisarg73
Copy link
Member

@Prernaswarna Apart from the changes I requested, there are few things you need to add, before we can merge this PR.

  • Add an icon by which a object can be distinguished as verified without actually going into its edit option.
  • Add a subtle note somewhere in edit menu in case of an verified object, for conveying that a verified object cannot be edited.
  • visibile boolean should be editable even if the object is verified. (I am not entirely sure about this, but perhaps @shreyansh23 can comment on this)
  • Make commit messages more descriptive and in present tense.

@Prernaswarna Prernaswarna requested a review from nisarg73 October 16, 2020 11:29
@shreyansh23
Copy link
Member

visibile boolean should be editable even if the object is verified. (I am not entirely sure about this, but perhaps @shreyansh23 can comment on this)

Yes, it makes more sense if visible boolean is also allowed to remain editable even after being verified.

@algomaster99
Copy link
Member

@Prernaswarna @nisarg73 what is the status?

@Prernaswarna
Copy link
Member Author

The backend doesn't allow changing verified visible boolean field. I asked Shreyansh about it I forgot to follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisarg73 nisarg73 Awaiting requested review from nisarg73

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Prernaswarna @nisarg73 @shreyansh23 @algomaster99