Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter only product.annotation_properties for each import #974

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

anitacaron
Copy link
Contributor

Fixes #814

@anitacaron
Copy link
Contributor Author

This is how it looks like when updating in RO

ANNOTATION_PROPERTIES=rdfs:label dc:description dc:source IAO:0000115 

$(IMPORTDIR)/envo_import.owl: $(MIRRORDIR)/envo.owl $(IMPORTDIR)/envo_terms_combined.txt
	if [ $(IMP) = true ]; then $(ROBOT) query -i $< --update ../sparql/preprocess-module.ru \
    extract -T $(IMPORTDIR)/envo_terms_combined.txt --copy-ontology-annotations true --force true --method BOT \
		remove --base-iri $(OBOBASE)/ENVO --axioms external --preserve-structure false --trim false \
		query --update ../sparql/inject-subset-declaration.ru --update ../sparql/inject-synonymtype-declaration.ru \
		remove $(patsubst %, --term %, $(ANNOTATION_PROPERTIES)) --term rdfs:label --term IAO:0000115  -T $(IMPORTDIR)/envo_terms_combined.txt --select complement --select "classes individuals annotation-properties" \
		$(ANNOTATE_CONVERT_FILE); fi

## Module for ontology: go

$(IMPORTDIR)/go_import.owl: $(MIRRORDIR)/go.owl $(IMPORTDIR)/go_terms_combined.txt
	if [ $(IMP) = true ]; then $(ROBOT) query -i $< --update ../sparql/preprocess-module.ru \
    extract -T $(IMPORTDIR)/go_terms_combined.txt --copy-ontology-annotations true --force true --method BOT \
		remove --base-iri $(OBOBASE)/GO --axioms external --preserve-structure false --trim false \
		query --update ../sparql/inject-subset-declaration.ru --update ../sparql/inject-synonymtype-declaration.ru \
		remove $(patsubst %, --term %, $(ANNOTATION_PROPERTIES)) --term IAO:0000116  -T $(IMPORTDIR)/go_terms_combined.txt --select complement --select "classes individuals annotation-properties" \
		$(ANNOTATE_CONVERT_FILE); fi

It didn't remove the other annotations when updating the import.

@anitacaron anitacaron self-assigned this Jan 8, 2024
@anitacaron anitacaron marked this pull request as ready for review January 29, 2024 19:49
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anitacaron assuming you have tested it, feel free to merge!

@matentzn matentzn added this to the 1.5 milestone Feb 24, 2024
@anitacaron anitacaron merged commit a12a10f into master Feb 28, 2024
1 check passed
@matentzn matentzn deleted the anitacaron/issue814 branch March 1, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile: importgroup.product.annotation_properties does not do anything
2 participants