Fix and refresh schema docs #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Commit extends the dump_schema() method in odk.py to allow dumping individual classes, rather than three classes concatenated.
This is now valid JSON file, previously it was three json files concatenated for no reason
This is not really a fix, but without it, schema_documentation.py throws an error when index('**') is called on a line without these symbols. This is acceptable because we need a better way for docs anyways, and no infromation is lost (looks a bit uglier though), cc @hkir-dev
A bit uglier then before, but still functional
|
@hkir-dev in case you did not see this yet - If I could get your recommendation on how to fix, I will gladly do it! |
|
It appears that the recent update to jsonschema2md is the root cause of the issue. I've applied a bug fix, but I believe your expertise could help identify any lingering problems more efficiently, @matentzn. Could you please review and inform me of any remaining issues? |
|
Thank you @hkir-dev for taking a look and adding a fix :) Looks ok for now, will cycle back on this later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hkir-dev this does not work perfectly anymore (the nesting does not work), see changes to schema_documentation.py.