Push SBOM to Maven central when releasing #6154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+260
to
+272
| <plugin> | ||
| <groupId>org.cyclonedx</groupId> | ||
| <artifactId>cyclonedx-maven-plugin</artifactId> | ||
| <version>2.9.1</version> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>makeAggregateBom</goal> | ||
| </goals> | ||
| <phase>package</phase> | ||
| </execution> | ||
| </executions> | ||
| </plugin> |
There was a problem hiding this comment.
Do we require it here as well? Spoon-core inherits spoon-pom.
Suggested change
| <plugin> | |
| <groupId>org.cyclonedx</groupId> | |
| <artifactId>cyclonedx-maven-plugin</artifactId> | |
| <version>2.9.1</version> | |
| <executions> | |
| <execution> | |
| <goals> | |
| <goal>makeAggregateBom</goal> | |
| </goals> | |
| <phase>package</phase> | |
| </execution> | |
| </executions> | |
| </plugin> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5255 , push sbom (cyclonedx) to maven central when releasing.
Added
cyclonedx-maven-plugintopom.xmlandspoon-javadoc/pom.xml.spoon-pomis actively updated on maven-central as well but from my understanding.Since JReleaser version
1.6.0it has support for additional artifacts in Maven deployers (jreleaser/jreleaser#1135 ). The version in nixpkgs unstable (used in spoon) is1.16.0- meaning the sbom will be included in CI as well.I then confirmed the sboms will be included in the upload by running the
chore/release.sh patchscript locally, modified to usejreleaser full-release --dry-runand not push anything to github. The output of that command can be seen below:Output of `jreleaser full-release --dry-run`