Moved to nvm to handle node installation. #984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/distributed-demo
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| https://deb.nodesource.com/node_%s.x nodistro main" "$NODE_MAJOR" | \ | ||
| sudo tee /etc/apt/sources.list.d/nodesource.list | ||
| curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash | ||
| export NVM_DIR="$([ -z "${XDG_CONFIG_HOME-}" ] && printf %s "${HOME}/.nvm" || printf %s "${XDG_CONFIG_HOME}/nvm")" |
There was a problem hiding this comment.
Declare and assign separately to avoid masking return values.
| sudo tee /etc/apt/sources.list.d/nodesource.list | ||
| curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash | ||
| export NVM_DIR="$([ -z "${XDG_CONFIG_HOME-}" ] && printf %s "${HOME}/.nvm" || printf %s "${XDG_CONFIG_HOME}/nvm")" | ||
| [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" # This loads nvm |
There was a problem hiding this comment.
Can't follow non-constant source. Use a directive to specify location.
| @@ -113,17 +113,23 @@ option with care. | |||
| To manage collaboration by multiple developers on the software, | |||
| a development workflow is in place. Each developer should follow these steps: | |||
|
|
|||
| <!-- | |||
| TODO Insert before Use fork,branch ... when githooks works | |||
|
Code Climate has analyzed commit 679fb79 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installs Node 22 through nvm instead of manually fetching packages. This fixes nvm for Linux for #962