add file previewers to dev env, more docs #11181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added
Component: Containers
pdurbin
commented
Jan 23, 2025
| @@ -97,7 +97,8 @@ services: | |||
| - DATAVERSE_URL=http://dataverse:8080 | |||
| - TIMEOUT=10m | |||
| - PREVIEWERS_PROVIDER_URL=http://${MACHINE_IP:-localhost}:9000 | |||
There was a problem hiding this comment.
Should we consider removing this MACHINE_IP stuff from this compose file? We already removed it from the dev version.
There was a problem hiding this comment.
I expect that it would make a lot of sense to be able to provide an alternative IP address (or host name) in a production environment. Leaving it in would be a good idea IMHO.
There was a problem hiding this comment.
Yeah, I suspect we'll dig into this more when we work on fronting Dataverse with some sort of proxy:
Kris-LIBIS
reviewed
Jan 30, 2025
|
@Kris-LIBIS great idea. I added the rm in 322b3a6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Developers like previewers too! Plus, we're adding some docs.
Which issue(s) this PR closes:
Special notes for your reviewer:
The previewers run on port 9080 in the development environment. In the demo/eval environment, they run on 9000 because MinIO isn't running (also on port 9000).
Suggestions on how to test this:
Try both the dev env and the "demo or eval" env.
Both should have all the previewers available.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Sort of? You can see previewers, like this:
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
https://dataverse-guide--11181.org.readthedocs.build/en/11181/container/running/demo.html#file-previewers