Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug in OAI-ORE exporter related to nested compound fields #11190

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vera
Copy link
Contributor

@vera vera commented Jan 27, 2025

What this PR does / why we need it:

This PR enables the OAI-ORE exporter to generate a metadata export for metadata containing nested compound fields (i.e. compound fields within compound fields).

Which issue(s) this PR closes:

Special notes for your reviewer:

/

Suggestions on how to test this:

  1. Create a metadata block containing nested compound fields, e.g. use one in here: nested_compound_test.tar.gz

    curl http://localhost:8080/api/admin/datasetfield/load -H "Content-type: text/tab-separated-values" -X POST --upload-file nested_compound_test2.tsv

  2. Enable metadata block

  3. Create a dataset using the metadata block, e.g. using a JSON file in the archive linked above

    curl -H "X-Dataverse-key: $API_TOKEN" -X POST "http://localhost:8080/api/dataverses/root/datasets" --upload-file nested_compound_test2.json -H 'Content-type:application/json'

  4. Go to http://localhost:8080/dataset.xhtml?persistentId=... (using PID returned by the API in 3.)

  5. Publish dataset

  6. Reload page

  7. Open "Metadata" tab, click "Export Metadata" button and select "OAI_ORE"

  8. Check that the export contains no errors: nested_compound_test2_oai_ore_export.json

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

/

Is there a release notes update needed for this change?:

/

Additional documentation:

/

@ofahimIQSS ofahimIQSS added the Size: 3 A percentage of a sprint. 2.1 hours. label Jan 28, 2025
@cmbz cmbz added FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Ready for Review ⏩
Development

Successfully merging this pull request may close these issues.

OAI-ORE exporter fails for too deeply nested metadata
3 participants