Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Access fixes #11203

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Jan 31, 2025

What this PR does / why we need it: As reported in dataverse.harvard.edu issue 247, when terms of use/terms of access cause the guestbook-terms-popup-fragment to appear and when guestbook at request is on, the dialog shows the basic guestbook questions when it shouldn't.

In investigating this, I also realized that the terms of access, if they exist, aren't show when a request for access was made from the per-file menus in the files table (versus selecting and using the button at the top).

This PR fixes both of these issues and makes text changes related to another comment in dataverse.harvard.edu issue 247 that try to clarify that the choice in the dataverse edit UI to select guestbooks at request or download is only a choice about the guestbook mode and only affects datasets where a guestbook is configured.

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Suggestions on how to test this: The bug fixes in this PR are only intended to affect the following two cases:

  • guestbooks at request, no guestbook, terms of use and/or terms of access requiring terms to show: the popup should not ask for name, email, etc. (see links to images in issue 247 above).
  • terms of access exist, and request for access or download made from the per-file dropdown menus in the file table: terms of access should be shown /the dialog should be the same as if you select the same file and use the request access/download button at the top of the table.
    Given the complexity of the code, its possible that the changes here affect other situations so regression testing to verify that the UI is unchanged when a guestbook exists, when terms of use/access aren't set, guestbook at download is configured, etc. should be done.

For the text changes, just verify that the dataverse edit/general info tab has an entry now called "Guestbook Mode" instead of "Guestbook Entry Option" and the popup help includes the phrase "(when configured for a dataset)".

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 10 A percentage of a sprint. 7 hours.
Projects
Status: Ready for Triage
Development

Successfully merging this pull request may close these issues.

1 participant