Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: As reported in dataverse.harvard.edu issue 247, when terms of use/terms of access cause the guestbook-terms-popup-fragment to appear and when guestbook at request is on, the dialog shows the basic guestbook questions when it shouldn't.
In investigating this, I also realized that the terms of access, if they exist, aren't show when a request for access was made from the per-file menus in the files table (versus selecting and using the button at the top).
This PR fixes both of these issues and makes text changes related to another comment in dataverse.harvard.edu issue 247 that try to clarify that the choice in the dataverse edit UI to select guestbooks at request or download is only a choice about the guestbook mode and only affects datasets where a guestbook is configured.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: The bug fixes in this PR are only intended to affect the following two cases:
Given the complexity of the code, its possible that the changes here affect other situations so regression testing to verify that the UI is unchanged when a guestbook exists, when terms of use/access aren't set, guestbook at download is configured, etc. should be done.
For the text changes, just verify that the dataverse edit/general info tab has an entry now called "Guestbook Mode" instead of "Guestbook Entry Option" and the popup help includes the phrase "(when configured for a dataset)".
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: