Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add van Hove function tutorials #13

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

ChiCheng45
Copy link
Collaborator

@ChiCheng45 ChiCheng45 commented Jan 22, 2025

Added tutorial 2 which goes through some background on the van Hove function and a step-by-step guide on calculating the van Hove function with MDANSE using a liquid argon trajectory.

Clean up some more files that were missed in #12.

Updated the conversion script in tutorial 1 so that it works with the new chunking change. Adjusted the tutorial 1 figures so that they have a smaller width and are centered to enhance readability.

@MBartkowiakSTFC feel free to make any typo fixes/changes etc.

@ChiCheng45 ChiCheng45 marked this pull request as draft January 22, 2025 17:20
@ChiCheng45 ChiCheng45 changed the title Chi/tutorial van hove Add van Hove function tutorials Jan 22, 2025
@ChiCheng45
Copy link
Collaborator Author

@MBartkowiakSTFC I'm unable to push to my branch for some reason I think you need to update the rules.

remote: error: GH013: Repository rule violations found for refs/heads/chi/tutorial-van-hove.
remote: Review all repository rules at https://github.com/ISISNeutronMuon/MDANSE-Examples/rules?ref=refs%2Fheads%2Fchi%2Ftutorial-van-hove
remote:
remote: - Changes must be made through a pull request.
remote:
To https://github.com/ISISNeutronMuon/MDANSE-Examples.git
 ! [remote rejected] chi/tutorial-van-hove -> chi/tutorial-van-hove (push declined due to repository rule violations)
error: failed to push some refs to 'https://github.com/ISISNeutronMuon/MDANSE-Examples.git'

@ChiCheng45 ChiCheng45 force-pushed the chi/tutorial-van-hove branch from 61f0ff3 to 7d0b975 Compare January 23, 2025 09:41
@ChiCheng45 ChiCheng45 marked this pull request as ready for review January 23, 2025 15:12
@ChiCheng45 ChiCheng45 marked this pull request as draft January 23, 2025 15:23
@ChiCheng45 ChiCheng45 marked this pull request as ready for review January 23, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant