Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 Adds more diagnostics info when pytest fails #159

Merged
merged 6 commits into from
Jun 19, 2024
Merged

🔨 Adds more diagnostics info when pytest fails #159

merged 6 commits into from
Jun 19, 2024

Conversation

pcrespov
Copy link
Member

What do these changes do?

  • Following up our discussion, I add some extra diagnostic info after a test fails. Specifically, the environment and a link to graylog with the times from start to end of the test
  • Updates pylint rules and adds settings.template.json to configure it correctly

Related issue/s

e2e only

How to test

For internal developers

@pcrespov pcrespov self-assigned this Jun 18, 2024
@pcrespov pcrespov added the enhancement New feature or request label Jun 18, 2024
@pcrespov pcrespov requested a review from bisgaard-itis June 18, 2024 14:15
@pcrespov pcrespov added this to the South Island Iced Tea milestone Jun 18, 2024
bisgaard-itis
bisgaard-itis approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Thanks a lot for the changes

clients/python/test/e2e/conftest.py Outdated Show resolved Hide resolved
.vscode/settings.template.json Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@pcrespov pcrespov merged commit 3054f30 into ITISFoundation:master Jun 19, 2024
8 checks passed
@pcrespov pcrespov deleted the e2e/tests branch June 19, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

Assignees

@pcrespov pcrespov

Labels
enhancement New feature or request
Projects
None yet
Milestone
South Island Iced Tea
Development

Successfully merging this pull request may close these issues.
2 participants
@pcrespov @bisgaard-itis