Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IncidentHistoryListItem: Fix icon for rule_matched event #118

Merged
merged 1 commit into from
Dec 19, 2023
Merged

IncidentHistoryListItem: Fix icon for rule_matched event #118

merged 1 commit into from
Dec 19, 2023

Conversation

raviks789
Copy link
Contributor

fixes #116

@raviks789 raviks789 requested a review from nilmerg September 14, 2023 14:16
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Sep 14, 2023
@raviks789 raviks789 self-assigned this Sep 14, 2023
nilmerg
nilmerg requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new icon in place, the height of the history rows changes. Why is that?

@nilmerg nilmerg added bug Something isn't working area/representation Affects the representation of information labels Sep 19, 2023
@raviks789
Copy link
Contributor Author

raviks789 commented Sep 28, 2023 •
edited
Loading

With the new icon in place, the height of the history rows changes. Why is that?

I have opened an issue (Icinga/ipl-web#209) for this in ipl-web.

@raviks789 raviks789 force-pushed the fix-rule-matched-icon branch from fc59713 to f6266d6 Compare September 28, 2023 13:39
@nilmerg nilmerg added this to the Preview #1 milestone Nov 30, 2023
@nilmerg nilmerg force-pushed the fix-rule-matched-icon branch from f6266d6 to 1ec6876 Compare December 13, 2023 12:53
@nilmerg nilmerg merged commit 3f69cf5 into main Dec 19, 2023
12 checks passed
@nilmerg nilmerg deleted the fix-rule-matched-icon branch December 19, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@raviks789 raviks789

Labels
area/representation Affects the representation of information bug Something isn't working cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
Beta
Development

Successfully merging this pull request may close these issues.

Incident History List: Fix icon for rule matched event
2 participants
@raviks789 @nilmerg