Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IcingaDB: limit several numbers not to crash Go daemon #10244

Merged
merged 2 commits into from
Jan 22, 2025
Merged

IcingaDB: limit several numbers not to crash Go daemon #10244

merged 2 commits into from
Jan 22, 2025

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov
IcingaDB::TimestampToMilliseconds(): limit output to four year digits
6b4378d 
Too high timestamps may overflow uint64_t (and the YYYY format) and negative
ones don't fit into uint64_t. Those may crash our Go daemon.
@Al2Klimov
IcingaDB#SerializeState(): limit execution_time and latency to 2^32-1
dd51b81 
not to write higher values into Redis than the Icinga DB schema can hold.
This fixes yet another potential Go daemon crash.
@cla-bot cla-bot bot added the cla/signed label Nov 15, 2024
@icinga-probot icinga-probot bot added this to the 2.13.11 milestone Nov 15, 2024
@icinga-probot icinga-probot bot added the area/icingadb New backend label Nov 15, 2024
@Al2Klimov Al2Klimov self-assigned this Nov 15, 2024
@icinga-probot icinga-probot bot added bug Something isn't working ref/IP labels Nov 15, 2024
@Al2Klimov Al2Klimov marked this pull request as ready for review November 15, 2024 16:08
@Al2Klimov Al2Klimov requested a review from oxzi January 22, 2025 10:05
@Al2Klimov Al2Klimov removed their assignment Jan 22, 2025
@Al2Klimov Al2Klimov merged commit fdfa11b into support/2.13 Jan 22, 2025
27 checks passed
@Al2Klimov Al2Klimov deleted the IcingaDB-int-range213 branch January 22, 2025 11:34
@oxzi oxzi mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxzi oxzi oxzi approved these changes

Assignees
No one assigned
Labels
area/icingadb New backend bug Something isn't working cla/signed ref/IP
Projects
None yet
Milestone
2.13.11
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @oxzi