Silence compiler warnings in code we don't maintain #9732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
added
the
core/quality
1 task
|
oxzi
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Could you please rebase this on the current master to rerun the checks?
According to the include_directories docs, setting SYSTEM "might achieve effects such as the compiler skipping warnings, or these fixed-install system files not being considered in dependency calculations". This is written with a big maybe. Can we be sure that this will not result in build failures on some platforms after #10225 was merged?
|
The W in -Wsuggest-override stands for warning, so it won't cause build failures unless someone uses -Werror. But yes, rebasing that PR after this one is merged is a good idea. |
Al2Klimov
force-pushed
the
silence-compiler-warnings-in-code-we-don-t-maintain
branch
from
c6ee729 to
6195a45
Compare
oxzi
approved these changes
Jan 14, 2025
julianbrost
deleted the
silence-compiler-warnings-in-code-we-don-t-maintain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.