Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of ipl/orm #129

Merged
merged 15 commits into from
Feb 1, 2023
Merged

Make use of ipl/orm #129

merged 15 commits into from
Feb 1, 2023

Conversation

yhabteab
Copy link
Member

@yhabteab yhabteab commented Sep 29, 2022

fixes #142
fixes #143

@cla-bot cla-bot bot added the cla/signed label Sep 29, 2022
@yhabteab yhabteab self-assigned this Sep 29, 2022
@yhabteab yhabteab added the enhancement New feature or improvement label Sep 29, 2022
@yhabteab yhabteab force-pushed the ipl-orm-support branch 5 times, most recently from 5954fd9 to 409c374 Compare October 5, 2022 13:56
@yhabteab yhabteab added this to the 1.2.0 milestone Oct 6, 2022
@yhabteab yhabteab marked this pull request as ready for review October 7, 2022 12:31
@yhabteab yhabteab requested review from nilmerg and lippserd and removed request for nilmerg October 7, 2022 12:32
@yhabteab yhabteab force-pushed the ipl-orm-support branch 4 times, most recently from 4127824 to 2dbad0d Compare October 18, 2022 12:21
@yhabteab
Copy link
Member Author

yhabteab commented Oct 18, 2022

@yhabteab yhabteab force-pushed the ipl-orm-support branch 4 times, most recently from d23ba86 to 5c1f279 Compare October 20, 2022 08:07
@yhabteab
Copy link
Member Author

Tests

CLI:

root@29b932b60d5f:/# icingacli x509 check --ip 10.211.55.31 --port 443
OK - Icinga Web 2 expires in 366 days|'Icinga Web 2'=31622836s;8553600:;3456000:;0;34214400
root@29b932b60d5f:/# icingacli x509 check --ip 10.211.55.31 --port 5665
OK - docker-master expires in 390 days|'docker-master'=33723335s;8557200:;3459600:;0;34300800
root@29b932b60d5f:/# icingacli x509 check --ip 10.211.55.31 --port 6379
OK - Icinga DB Redis expires in 366 days|'Icinga DB Redis'=31623859s;8553600:;3456000:;0;34214400

Director hooks 🪝:
Bildschirmfoto 2022-10-20 um 10 10 12

Certificate Usages:
Bildschirmfoto 2022-10-20 um 10 12 04

Host Details:
Bildschirmfoto 2022-10-20 um 10 13 32

Certificate Overview:
Bildschirmfoto 2022-10-20 um 10 15 17

Certificate Details:
Bildschirmfoto 2022-10-20 um 10 16 21

@yhabteab yhabteab force-pushed the ipl-orm-support branch 3 times, most recently from 2704179 to 12178a4 Compare October 25, 2022 11:57
@yhabteab yhabteab mentioned this pull request Nov 2, 2022
@yhabteab yhabteab force-pushed the ipl-orm-support branch 2 times, most recently from dc1903d to 922f298 Compare December 5, 2022 12:02
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the requested changes, please use double quotes for strings containing single quotes instead of escaping them.

library/X509/Job.php Outdated Show resolved Hide resolved
library/X509/Job.php Show resolved Hide resolved
library/X509/Job.php Show resolved Hide resolved
library/X509/Job.php Outdated Show resolved Hide resolved
library/X509/Model/Behavior/DistinguishedEncodingRules.php Outdated Show resolved Hide resolved
library/X509/Model/Behavior/Ip.php Show resolved Hide resolved
application/clicommands/CheckCommand.php Outdated Show resolved Hide resolved
library/X509/Job.php Outdated Show resolved Hide resolved
@lippserd lippserd merged commit 6eeeeb6 into master Feb 1, 2023
@lippserd lippserd deleted the ipl-orm-support branch February 1, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always show complete chain Random ordering in certificate dashboard
3 participants