Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training: Add unit tests and change datatype of two columns #1159

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

blackcoder87
Copy link
Member

@blackcoder87 blackcoder87 commented Jan 16, 2025

Description

  • Added unit tests.
  • Changed datatype of two columns.
  • Adjusted the training model.
  • Adjusted the entrants model.

The columns "voice_server" and "game_server" don't need to be of type INT when they only should represent a boolean value.
Changed them to TINYINT.

`voice_server` TINYINT(1) NOT NULL DEFAULT 0,
`game_server` TINYINT(1) NOT NULL DEFAULT 0,

The id of a training model can never be 0 as it is a primary key in the trainings table.

`id` INT(11) NOT NULL AUTO_INCREMENT,

The id of the training and user id in the training_entrants table have a FKC to the respective columns of the training and user table. They can never have the value 0.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

This PR has been tested in the following browsers:

  • Chrome
  • Firefox
  • Opera
  • Edge

@blackcoder87 blackcoder87 merged commit ac21db7 into master Jan 16, 2025
6 checks passed
@blackcoder87 blackcoder87 deleted the training-unit-tests-datatypes branch January 16, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant