Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional fellowship switch #280

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Optional fellowship switch #280

merged 5 commits into from
Dec 5, 2023

Conversation

f-gate
Copy link
Member

@f-gate f-gate commented Nov 30, 2023

solves: #192

API changes

You now have to pass in wether you need the applicant to be a Role::Freelancer.
It will check pallet_fellowship to see wether this is the case.

pub fn create_brief(
            origin: OriginFor<T>,
            mut brief_owners: BoundedBriefOwners<T>,
            applicant: AccountIdOf<T>,
            budget: BalanceOf<T>,
            initial_contribution: BalanceOf<T>,
            brief_id: BriefHash,
            currency_id: CurrencyId,
            milestones: BoundedProposedMilestones<T>,
            require_fellowship: bool,
        ) -> DispatchResult

Migrations

No migrations needed, since applicant is checked on creation there is no need to save it to the brief type.

@f-gate f-gate changed the base branch from main to staging December 5, 2023 13:34
@f-gate f-gate merged commit 210ccc3 into staging Dec 5, 2023
3 checks passed
@f-gate f-gate deleted the optional-fellowship-switch branch December 5, 2023 13:55
samelamin added a commit that referenced this pull request Dec 9, 2023
* staging check for prs to main

* remove run gcp for push to staging

* Optional fellowship switch (#280)

* add test for approved applicant

* fmt

* add ensure role to runtime

---------

Co-authored-by: Sam Elamin <[email protected]>

* Foreign token minting tests (#282)

* test

* forign signer can mint

* negative minting test

* remove it (#285)

* Autofinalise dispute where jury size == 1 (#279)

* autocomplete dispute where jury size = 1

* refactor tests to include jury

* fmt

* give briefs a jury!

* fmt

* fix tests from merge

* remove it (#285)

---------

Co-authored-by: Sam Elamin <[email protected]>

* clear votes with tests (#289)

* Eoa field (#287)

* new types

* ensure supported currency method

* brief migration, fixes

* fixes

* fmt

* fix up benchmarks

* fix brief test

* update imbue image for rococo

* clear votes with tests

* fix merge

* fix

* fix

* fmt

* fix

---------

Co-authored-by: samelamin <[email protected]>

* bump up the version to match polkadot packages

---------

Co-authored-by: Sam Elamin <[email protected]>
f-gate added a commit that referenced this pull request Dec 11, 2023
* staging check for prs to main

* remove run gcp for push to staging

* Optional fellowship switch (#280)

* add test for approved applicant

* fmt

* add ensure role to runtime

---------

Co-authored-by: Sam Elamin <[email protected]>

* Foreign token minting tests (#282)

* test

* forign signer can mint

* negative minting test

* remove it (#285)

* Autofinalise dispute where jury size == 1 (#279)

* autocomplete dispute where jury size = 1

* refactor tests to include jury

* fmt

* give briefs a jury!

* fmt

* fix tests from merge

* remove it (#285)

---------

Co-authored-by: Sam Elamin <[email protected]>

* new benchmarks template

* remove old script

* benchmark script :)

* hmm

* clear votes with tests (#289)

* Eoa field (#287)

* new types

* ensure supported currency method

* brief migration, fixes

* fixes

* fmt

* fix up benchmarks

* fix brief test

* update imbue image for rococo

* clear votes with tests

* fix merge

* fix

* fix

* fmt

* fix

---------

Co-authored-by: samelamin <[email protected]>

* add default fellows to selector, fix template

* fiddle

* generate new weights using script

* fmt

* use release profile

---------

Co-authored-by: Sam Elamin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants