Templated form elements #1584
Open
Templated form elements #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function name should be a string.
…ic markup for forms.
MekDrop
requested changes
Feb 7, 2025
| /** | ||
| * template for this field | ||
| */ | ||
| protected icms_view_Tpl $_tpl; |
There was a problem hiding this comment.
can we for new vars not use _ prefix? it's doesn't make sense
There was a problem hiding this comment.
I believe it was in the early PHP4 days a convention to show that it was a protected variable. You are right, it doesn't make any sense anymore and I'll change it.
Comment on lines
+119
to
+124
| $this->_tpl = new icms_view_Tpl(); | ||
| $this->_tpl->assign('type', $this->getType()); | ||
| $this->_tpl->assign('name', $this->getName()); | ||
| $this->_tpl->assign('id', $this->getName()); | ||
| $this->_tpl->assign('value', $this->getValue()); | ||
| $this->_tpl->assign('extra', $this->getExtra()); |
There was a problem hiding this comment.
some formatting issue I think is here? somehow it's looks without indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS frameworks (Bulma, Bootstrap, Tailwind, ...) and almost every theme out there need specific HTML markup for their form solution to work well. The HTML implementation in the core was not flexible enough to allow that. I started with a button, and will gradually transform all hardcoded HTML in the core to using templates.
I've started with these 4:
Other parts will come in other PRs
Smarty is included in the core specifically for this kind of functionality, so let's not re-invent the wheel.
Added benefit : by using Smarty we should also have template caching, for that extra micro-second of speed :-)