Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename circuit_index in QCVV library #1144

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Rename circuit_index in QCVV library #1144

merged 4 commits into from
Jan 23, 2025

Conversation

cdbf1
Copy link
Contributor

@cdbf1 cdbf1 commented Jan 20, 2025

Rename circuit_index -> circuit_realization in the QCVV Sample object to avoid possible confusion

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

bharat-thotakura
bharat-thotakura approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@bharat-thotakura bharat-thotakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

supermarq-benchmarks/supermarq/qcvv/base_experiment.py Outdated Show resolved Hide resolved
@cdbf1 cdbf1 merged commit 43be120 into main Jan 23, 2025
21 checks passed
@cdbf1 cdbf1 deleted the feature/rename_qcvv_circuit_index branch January 23, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharat-thotakura bharat-thotakura bharat-thotakura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdbf1 @bharat-thotakura