fix: Don't use .all { } if the list is empty, it will always return true
#1522
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
force-pushed
the
clean-code
branch
2 times, most recently
from
6ac1bdb to
ec7f01a
Compare
tevincent
approved these changes
Feb 11, 2025
KevinBoulongne
force-pushed
the
clean-code
branch
from
ec7f01a to
a86e7bd
Compare
|
This PR/issue depends on: |
KevinBoulongne
force-pushed
the
clean-code
branch
from
a86e7bd to
1a11e1a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Infomaniak/android-core#278