fix: upgrade node 16 -> 18

Informatievlaanderen · Dec 14, 2022 · 93feee6 · 93feee6
1 parent c07783d
commit 93feee6
Show file tree

Hide file tree

Showing 10 changed files with 103 additions and 196 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -48,6 +48,8 @@ jobs:
 
     - name: Setup Node.js
       uses: actions/setup-node@v3
+      with:
+        node-version: 18
 
     - name: Setup .NET Core
       uses: actions/setup-dotnet@v2

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16.15.0
+18.12.1
diff --git a/README.md b/README.md
@@ -6,12 +6,12 @@
 
 NVM: ([Windows][1], [unix, macOS, windows WSL](2))
 
-Node: **v16.15.0** *(do this with nvm)*
+Node: **v18.12.1** *(do this with nvm)*
 
-NPM: **v8.5.5** *(nvm handles this too)*
+NPM: **v8.19.2** *(nvm handles this too)*
 
 ``` bash
-nvm install 16.15.0 
+nvm install 18.12.1
 ```
 
 [1]:(https://github.com/coreybutler/nvm-windows)

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -138,7 +138,7 @@
     "fail": false
   },
   "engines": {
-    "node": ">= 16.15.0",
-    "npm": ">= 8.5.5"
+    "node": ">= 18.12.1",
+    "npm": ">= 8.19.2"
   }
 }
diff --git a/site/.nvmrc b/site/.nvmrc
@@ -1 +1 @@
-16.15.0
+18.12.1
diff --git a/site/Dockerfile b/site/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:16.15.0-alpine as build-stage
+FROM node:18.12.1-alpine as build-stage
 LABEL maintainer "Digitaal Vlaanderen <[email protected]>"
 ARG NPM_TOKEN
 WORKDIR /app

diff --git a/site/README.md b/site/README.md
@@ -6,12 +6,12 @@
 
 NVM: ([Windows][1], [unix, macOS, windows WSL](2))
 
-Node: **v16.15.0** *(do this with nvm)*
+Node: **v18.12.1** *(do this with nvm)*
 
-NPM: **v8.5.5** *(nvm handles this too)*
+NPM: **v8.19.2** *(nvm handles this too)*
 
 ``` bash
-nvm install 16.15.0
+nvm install 18.12.1
 ```
 
 [1]:(https://github.com/coreybutler/nvm-windows)