Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clarify job names #1601

Merged
merged 1 commit into from
Jan 23, 2025
Merged

ci: clarify job names #1601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/deploy-single.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,15 +217,15 @@ jobs:
deploy_finish_slack:
if: github.repository_owner == 'Informatievlaanderen'
needs: [deploy_services, deploy_tasks, deploy_lambda]
name: Deploy finished
name: Notify deployment succeeded
runs-on: ubuntu-latest

steps:
- name: Parse repository name
run: echo REPOSITORY_NAME=$(echo ""$GITHUB_REPOSITORY"" | awk -F / '{print $2}' | sed -e ""s/:refs//"") >> $GITHUB_ENV
shell: bash

- name: Notify deployment finished
- name: Notify deployment succeeded
uses: slackapi/[email protected]
with:
channel-id: '#team-wegenregister-dev'
Expand All @@ -238,7 +238,7 @@ jobs:
deploy_nothing_slack:
if: github.repository_owner == 'Informatievlaanderen' && (github.event.inputs.service == '' || github.event.inputs.task == '' || github.event.inputs.lambda == '')
needs: [deploy_services, deploy_tasks, deploy_lambda]
name: Deploy cancelled
name: Notify deployment cancelled
runs-on: ubuntu-latest

steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ jobs:
deploy_lambda_prd:
if: github.repository_owner == 'Informatievlaanderen' && github.event.inputs.environment == 'prd'
needs: [deploy_services, deploy_tasks]
name: Deploy lambda(s)
name: Deploy lambda(s) prd
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -257,15 +257,15 @@ jobs:
deploy_finish_slack:
needs: [system_healthcheck]
if: ${{ github.repository_owner == 'Informatievlaanderen' && always() && needs.system_healthcheck.result == 'success' }}
name: Deploy finished
name: Notify deployment succeeded
runs-on: ubuntu-latest

steps:
- name: Parse repository name
run: echo REPOSITORY_NAME=$(echo ""$GITHUB_REPOSITORY"" | awk -F / '{print $2}' | sed -e ""s/:refs//"") >> $GITHUB_ENV
shell: bash

- name: Notify deployment finished
- name: Notify deployment succeeded
uses: slackapi/[email protected]
with:
channel-id: '#team-wegenregister-dev'
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,15 +971,15 @@ jobs:
deploy_to_test_finish_slack:
if: github.repository_owner == 'Informatievlaanderen'
needs: [ release, system_healthcheck ]
name: Deploy to test finished
name: Notify deployment succeeded
runs-on: ubuntu-latest

steps:
- name: Parse repository name
run: echo REPOSITORY_NAME=$(echo ""$GITHUB_REPOSITORY"" | awk -F / '{print $2}' | sed -e ""s/:refs//"") >> $GITHUB_ENV
shell: bash

- name: Notify deployment finished
- name: Notify deployment succeeded
uses: slackapi/[email protected]
with:
channel-id: '#team-wegenregister-dev'
Expand All @@ -991,16 +991,16 @@ jobs:

build_notify_skipped:
if: ${{ (github.repository_owner == 'Informatievlaanderen') && (needs.set-release-version.outputs.version == 'none') }}
name: Notify release skipped
name: Notify build skipped
needs: [ set-release-version ]
runs-on: ubuntu-latest
steps:
- name: Notify release skipped
- name: Notify build skipped
id: slack
uses: slackapi/[email protected]
with:
channel-id: '#team-wegenregister-dev'
slack-message: ":x: Release of road-registry has been skipped. View run at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
slack-message: ":x: Build of road-registry has been skipped. View run at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
env:
SLACK_BOT_TOKEN: ${{ secrets.VBR_SLACK_BOT_TOKEN }}
SLACK_CHANNEL: ${{ secrets.VBR_NOTIFIER_CHANNEL_NAME }}
Expand Down
Loading