WIP: GraphQL API (public parts) #888
Conversation
…. Add some extra info to pageInfo object
…nd fields, fix videos filter
…le-to-graphql Add the activities module to graphql
…le-to-graphql Add descriptions to attributes and their translations
Add the companies module to the graphql api
…-the-graphql-api Add about pages to the GraphQL API
…-to-the-graphql-api 825 add the calendar module to the graphql api
…ional-bouquet Add mutation for the educational bouquet
# Conflicts: # locale/nl/LC_MESSAGES/django.mo # locale/nl/LC_MESSAGES/django.po
|
Some (previously) private information is currently made public that we (probably) don't want: ActivityType: (something seems to go wrong with the fields specification here as well)
CommitteeType:
AttachmentType:
WebsiteBannerType / TelevisionBannerType / VivatBannerType:
Rest looks good as far as I can tell! |
|
We probably should also add unit tests for each attribute that is only shown when authenticated, to make sure it doesn't end up being publicly available at a later point. Graphene has some facilities for this: https://docs.graphene-python.org/projects/django/en/latest/testing/ |
…rivate fields for Events and Committees
… start and end date for banners being exposed.
…ducation and companies
This concludes our testing initiative, thanks for testing!
|
As far as I can tell, the tests are as done as they could be for now. |
…ication Add authorization levels to GraphQL
|
New todo: Convert existing GraphQL moduels to the new authorization format. |
Please add the following information to your pull request:
Please describe what your PR is fixing
Adds a GraphQL API for public resources.
Concretely, which issues does your PR solve? (Please reference them by typing
Fixes/References Inter-Actief/amelie#<issue_id>)Fixes #741
Does your PR change how we process personal data, impact our privacy document, or modify (one of) our data export(s)?
no
Does your PR include any django migrations?
no
Does your PR include the proper translations (did you add translations for new/modified strings)?
yes, I have included the translations
Does your PR include CSS changes (and did you run the
compile_css.shscript in thescriptsdirectory to regenerate thecompiled.cssfile)?no, my PR does not include CSS changes
Does your PR need external actions by for example the System Administrators? (Think about new pip packages, new (local) settings, a new regular task or cronjob, new management commands, etc.)?
no
Did you properly test your PR before submitting it?
yes