Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update TCModelFactory to accept GVL parameter in methods #468

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: update TCModelFactory to accept GVL parameter in methods #468

wants to merge 1 commit into from

Conversation

harrykingriches
Copy link

Relates to #466

HeinzBaumann
HeinzBaumann approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@HeinzBaumann HeinzBaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@HeinzBaumann
Copy link
Collaborator

@lamrowena we should pick this up, next time we do a build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinzBaumann HeinzBaumann HeinzBaumann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrykingriches @HeinzBaumann