Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golden tests to use the new text envelope format #1052

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update golden tests to use the new text envelope format #1052

wants to merge 2 commits into from

Conversation

palas
Copy link
Contributor

@palas palas commented Feb 4, 2025

Changelog

- description: |
    Updated golden tests to use the new text envelope format
  type:
  - maintenance

Context

This PR is based on cardano-api's IntersectMBO/cardano-api#746 that removes serialiseTxLedgerCddl and deserialiseTxLedgerCddl which have been deprecated for two months. It also updates writeTxFileTextEnvelopeCddl which was using the old format. This PR updates golden tests so that the use the new format in cardano-cli.

How to trust this PR

Make sure the changes in the tests make sense and are expected. Possibly review the PR together with IntersectMBO/cardano-api#746

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas self-assigned this Feb 4, 2025
@palas palas linked an issue Feb 4, 2025 that may be closed by this pull request
Remove deprecated functions and update types and update writeTxFileTextEnvelopeCddl to use new format #1051
Open
@palas palas added the next-update Needs a dependency to be updated to be merged label Feb 4, 2025
@palas palas mentioned this pull request Feb 4, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer is a code owner

@smelc smelc Awaiting requested review from smelc smelc is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@palas palas

Labels
next-update Needs a dependency to be updated to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated functions and update types and update writeTxFileTextEnvelopeCddl to use new format
1 participant
@palas