-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Governance rollback tests #1898
Conversation
b785e9e
to
00b823c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my limited understanding of Governance these tests seem correct to me. One very minor comment that can be ignored.
🚢
void (Api.registerDRepsAndDelegateVotes interpreter server) | ||
let | ||
-- Propose a new committee member | ||
committee1Hash = "e0a714319812c3f773ba04ec5d6b3ffcd5aad85006805b047b082541" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor but is it worth abstracting this hash out as it's used in 2 places? Happy to leave as is tbh.
Move out new committee credentials to Forging module
82190e7
to
5fc5339
Compare
Description
Addresses #1572. Add some more Conway tests:
Checklist
fourmolu
on version 0.10.1.0 (which can be run withscripts/fourmolize.sh
)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.