Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Governance rollback tests #1898

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

sgillespie
Copy link
Contributor

@sgillespie sgillespie commented Nov 13, 2024

Description

Addresses #1572. Add some more Conway tests:

  • rollback new committee member (enacted)
  • rollback new committee proposal (not ratified)
  • chained new committee proposals
  • rollback hard fork

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@sgillespie sgillespie marked this pull request as ready for review November 21, 2024 21:24
@sgillespie sgillespie requested a review from a team as a code owner November 21, 2024 21:24
Cmdv
Cmdv previously approved these changes Dec 3, 2024
Copy link
Contributor

@Cmdv Cmdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my limited understanding of Governance these tests seem correct to me. One very minor comment that can be ignored.

🚢 :shipit:

void (Api.registerDRepsAndDelegateVotes interpreter server)
let
-- Propose a new committee member
committee1Hash = "e0a714319812c3f773ba04ec5d6b3ffcd5aad85006805b047b082541"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor but is it worth abstracting this hash out as it's used in 2 places? Happy to leave as is tbh.

@kderme kderme merged commit e4a0980 into IntersectMBO:master Jan 21, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants