Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1906 - Add cache for address #1916

Merged
merged 1 commit into from
Jan 21, 2025
Merged

1906 - Add cache for address #1916

merged 1 commit into from
Jan 21, 2025

Conversation

Cmdv
Copy link
Contributor

@Cmdv Cmdv commented Dec 3, 2024

Description

This fixes #1906

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@Cmdv Cmdv requested a review from a team as a code owner December 3, 2024 22:15
@Cmdv Cmdv marked this pull request as draft December 3, 2024 22:15
@Cmdv Cmdv force-pushed the 1906-add-caching-for-address branch 3 times, most recently from 540d83f to 84ba497 Compare December 4, 2024 10:48
@Cmdv Cmdv marked this pull request as ready for review December 4, 2024 10:48
kderme
kderme approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@kderme kderme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would be great to have this tested on some testnet.

@Cmdv Cmdv force-pushed the 1906-add-caching-for-address branch from 84ba497 to a885d88 Compare January 15, 2025 10:15
@Cmdv Cmdv merged commit 070a307 into master Jan 21, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kderme kderme kderme approved these changes

@sgillespie sgillespie sgillespie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Caching for Address table when config enabled
3 participants
@Cmdv @sgillespie @kderme