-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increased the probability of generating the same hash more than once #4543
Conversation
b263ca0
to
80cb218
Compare
e8466ee
to
5aba417
Compare
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Conway/Base.hs
Show resolved
Hide resolved
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Conway/Base.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message of the first commit seems totally unrelated to the content - i would squash it with the second one to avoid confusion.
Looks good to me otherwise, just a few questions.
3e308de
to
9b3bc57
Compare
6d4375d
to
0256b0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Needs a manual rebase, since there are some conflicts (likely due to SRP)
a6d10e2
to
6e5001d
Compare
6e5001d
to
64c5713
Compare
Description
This is supposed to make it easier to find a counterexample for IntersectMBO/formal-ledger-specifications#514
I managed to catch the bug with the modified generators by making it more likely to generate the same credential in multiple places. I also created an ImpTest that uses a manually constructed state to reproduce the bug.
Checklist
CHANGELOG.md
for the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)