-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ts additions prime spec cert steps #4546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54cb22a
to
12e55de
Compare
12e55de
to
2bcdc27
Compare
I have brought this branch up to date with the changes that have been merged to master, and the changes that were made in the "Alternative steps" branch that this branch is based on. |
07b1cfa
to
13eb5e3
Compare
Rebased against master again, in order to get rid of the commits that have already been merged to master. |
daa874b
to
81fb583
Compare
Soupstraw
reviewed
Aug 29, 2024
.../cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Conway/Certs.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Aug 29, 2024
.../cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Conway/Certs.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Aug 29, 2024
.../cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Conway/Certs.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Aug 29, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/GovCert.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Aug 29, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/GovCert.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Aug 29, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/GovCert.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Aug 29, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/Cert.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Aug 29, 2024
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Core.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Aug 29, 2024
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Core.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Aug 29, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/Certs.hs
Outdated
Show resolved
Hide resolved
4daec85
to
e095507
Compare
Soupstraw
reviewed
Sep 5, 2024
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Generator/Utxo.hs
Show resolved
Hide resolved
Soupstraw
reviewed
Sep 5, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/Cert.hs
Outdated
Show resolved
Hide resolved
e65a930
to
50e58fa
Compare
Soupstraw
approved these changes
Sep 6, 2024
be (xprop "GOV") PR 4584 should fix this when merged
…n and spec. Added Minitrace CERTS tests. Added fixup on CERTS conformance tests, because Spec zeros out rewards for withdrawals, and the Haskell code does not.
50e58fa
to
d95682d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the CERTS conformance rule working.
This is complicated because of slight differences between the implementation and the spec.
These difference come in two flavors
This PR was complicated by a bug in the MAlonzo code, that has now been fixed.
Checklist
CHANGELOG.md
for the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)