Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts additions prime spec cert steps #4546

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

TimSheard
Copy link
Contributor

@TimSheard TimSheard commented Aug 13, 2024

Get the CERTS conformance rule working.
This is complicated because of slight differences between the implementation and the spec.
These difference come in two flavors

  1. The spec makes more tests than the implementation using the withdrawals which are not part of the implementation. The solution to these difference is to randomly generate more refined inputs, which will make the spec tests pass, and will be ignored by the implementation.
  2. The Spec zeros out the reward balances for the withdrawals. The solution to this is to "fixup" the implementation test by zeroing out its reward balances for the withdrawals before comparing the final states of the implementation and the spec.

This PR was complicated by a bug in the MAlonzo code, that has now been fixed.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@TimSheard TimSheard force-pushed the ts-additions-prime-spec-cert-steps branch 2 times, most recently from 54cb22a to 12e55de Compare August 20, 2024 19:38
@teodanciu teodanciu force-pushed the ts-additions-prime-spec-cert-steps branch from 12e55de to 2bcdc27 Compare August 21, 2024 09:34
@teodanciu
Copy link
Contributor

I have brought this branch up to date with the changes that have been merged to master, and the changes that were made in the "Alternative steps" branch that this branch is based on.

@teodanciu teodanciu force-pushed the ts-additions-prime-spec-cert-steps branch 2 times, most recently from 07b1cfa to 13eb5e3 Compare August 22, 2024 11:17
@teodanciu
Copy link
Contributor

Rebased against master again, in order to get rid of the commits that have already been merged to master.

@TimSheard TimSheard force-pushed the ts-additions-prime-spec-cert-steps branch 2 times, most recently from daa874b to 81fb583 Compare August 27, 2024 18:25
@TimSheard TimSheard force-pushed the ts-additions-prime-spec-cert-steps branch 4 times, most recently from 4daec85 to e095507 Compare September 4, 2024 19:24
@TimSheard TimSheard requested a review from lehins September 4, 2024 19:26
@TimSheard TimSheard force-pushed the ts-additions-prime-spec-cert-steps branch 2 times, most recently from e65a930 to 50e58fa Compare September 6, 2024 02:10
be (xprop "GOV") PR 4584 should fix this when merged
…n and spec.

Added Minitrace CERTS tests.
Added fixup on CERTS conformance tests, because Spec zeros out rewards for withdrawals, and the Haskell code does not.
@TimSheard TimSheard force-pushed the ts-additions-prime-spec-cert-steps branch from 50e58fa to d95682d Compare September 6, 2024 19:40
@TimSheard TimSheard enabled auto-merge (squash) September 6, 2024 21:17
@TimSheard TimSheard merged commit d0d0750 into master Sep 6, 2024
158 checks passed
@TimSheard TimSheard deleted the ts-additions-prime-spec-cert-steps branch September 6, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants