Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Imp tests with realistic SPO voting thresholds #4561

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Aug 23, 2024

Description

Resolves #4329

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky Lucsanszky force-pushed the ldan/realistic-spo-thresholds branch 3 times, most recently from 140ff7e to 1413bb5 Compare August 27, 2024 19:41
@Lucsanszky Lucsanszky requested review from teodanciu and lehins August 27, 2024 19:43
@Lucsanszky Lucsanszky marked this pull request as ready for review August 27, 2024 19:43
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@lehins lehins force-pushed the ldan/realistic-spo-thresholds branch from 1413bb5 to 4f6f3dc Compare August 28, 2024 01:00
@lehins lehins enabled auto-merge August 28, 2024 01:00
@lehins lehins merged commit e9c64b3 into master Aug 28, 2024
154 checks passed
@lehins lehins deleted the ldan/realistic-spo-thresholds branch August 28, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Imp tests have realistic initial SPO thresholds
2 participants