Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TxInfo memoization #4854

Merged
merged 4 commits into from
Jan 30, 2025
Merged

TxInfo memoization #4854

merged 4 commits into from
Jan 30, 2025
+104 −37

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jan 24, 2025 •
edited
Loading

Description

Resolves #4851

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins marked this pull request as ready for review January 24, 2025 19:14
@lehins lehins requested a review from a team as a code owner January 24, 2025 19:14
@lehins lehins force-pushed the lehins/TxInfo-memoization branch from 654df5b to 7621144 Compare January 24, 2025 19:14
teodanciu
teodanciu approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@teodanciu teodanciu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised to learn that txInfo is the same for all scripts of the transaction, good to know.
Looks good to me.

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Plutus/Evaluate.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/CHANGELOG.md Show resolved Hide resolved
@lehins lehins force-pushed the lehins/TxInfo-memoization branch from 082413d to 6caaebf Compare January 29, 2025 23:20
@lehins lehins enabled auto-merge January 29, 2025 23:20
@lehins lehins merged commit c9e2fda into master Jan 30, 2025
158 of 162 checks passed
@lehins lehins deleted the lehins/TxInfo-memoization branch January 30, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodanciu teodanciu teodanciu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memoize TxInfo for every transaction
2 participants
@lehins @teodanciu