Merge pull request #5063 from IntersectMBO/mwojtowicz/release/ourobor…

…os-network-0.19 Fix rethrow policy
IntersectMBO · Feb 3, 2025 · 6065cff · 6065cff
2 parents 062b7b7 + 62e0887
commit 6065cff
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -23,7 +23,7 @@ jobs:
 
     env:
       # Modify this value to "invalidate" all cabal caches.
-      CABAL_CACHE_VERSION: "2024-05-22"
+      CABAL_CACHE_VERSION: "2025-02-03"
       # Modify this value to "invalidate" the cabal store cache only.
       CACHE_VERSION: "20220919"
       # Modify this value to "invalidate" the dist-newstyle cache only.

diff --git a/ouroboros-network/CHANGELOG.md b/ouroboros-network/CHANGELOG.md
@@ -8,6 +8,12 @@
 
 ## 0.19.0.2 -- 2025-02-03
 
+### Breaking changes
+
+### Non-breaking changes
+
+* UnknownMiniProtocol error should not crash the node
+
 ## 0.19.0.1 -- 2025-01-15
 
 ### Breaking changes

diff --git a/ouroboros-network/src/Ouroboros/Network/Diffusion/P2P.hs b/ouroboros-network/src/Ouroboros/Network/Diffusion/P2P.hs
@@ -745,11 +745,8 @@ runM Interfaces
           Nothing -> mempty)
       <>
       RethrowPolicy (\ctx err -> case  (ctx, fromException err) of
-                        -- mux unknown mini-protocol errors on the outbound
-                        -- side are fatal, since this is misconfiguration of the
-                        -- ouroboros-network stack.
                         (OutboundError, Just Mx.UnknownMiniProtocol {})
-                          -> ShutdownNode
+                          -> ShutdownPeer
                         _ -> mempty)