Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mux Readbuffer #5071

Draft
wants to merge 5 commits into
base: release/ouroboros-network-0.17.1.2
Choose a base branch
from
Draft

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Feb 6, 2025

Description

Reading a Mux segment used to require at least two syscalls.
One two read the header and one to read the rest of the data.

This change reads up to RecvBuffer bytes into a buffer in one go and
then serves data from it.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@karknu karknu changed the base branch from main to release/ouroboros-network-0.17.1.2 February 6, 2025 21:22
Lower level benchmark for reading and writing over Sockets.
Uses local TCP sockets over ephemeral ports.
@karknu karknu force-pushed the karknu/read_buffer branch 2 times, most recently from ed8161c to 63f6e67 Compare February 11, 2025 13:13
Reading a Mux segment used to require at least two syscalls.
One two read the header and one to read the rest of the data.

This change reads up to RecvBuffer bytes into a buffer in one go and
then serves data from it.
Enforce at least 1 byte payload data per SDU.
Permit sending of multiple SDUs through a single call to sendMany for
Socket bearers
Bearers without vector IO support emulate it through multiple calls to
write.
@karknu karknu force-pushed the karknu/read_buffer branch 2 times, most recently from d5bc899 to 74a1161 Compare February 11, 2025 14:13
@karknu karknu force-pushed the karknu/read_buffer branch from 74a1161 to 017aa8f Compare February 11, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant