Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the CDDL spec of the LocalStateQuery mini-protocol #5074

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geo2a
Copy link

@geo2a geo2a commented Feb 10, 2025

Description

This is a draft PR that may address IntersectMBO/ouroboros-consensus#1370. See the issue for further discussion, as it is not clear is ouroboros-network is the right place for this change.

This PR:

The query type is modeled after the one defined in Ouroboros.Consensus.Ledger.Query, which is used to instantiate the LocalStateQuery in the Consensus code.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@geo2a geo2a force-pushed the geo2a/consensus-issue-1370-refine-local-state-query branch from 6073392 to 3d541f4 Compare February 11, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant