The Hashable instance for Name should only depend on the unique (#5714)

IntersectMBO · Jan 12, 2024 · 607c501 · 607c501
1 parent 09aa41a
commit 607c501
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/plutus-core/plutus-core/src/PlutusCore/Name.hs b/plutus-core/plutus-core/src/PlutusCore/Name.hs
@@ -61,7 +61,7 @@ data Name = Name
   -- ^ A 'Unique' assigned to the name, allowing for cheap comparisons in the compiler.
   }
   deriving stock (Show, Generic, Lift)
-  deriving anyclass (NFData, Hashable)
+  deriving anyclass (NFData)
 
 -- | Allowed characters in the starting position of a non-quoted identifier.
 isIdentifierStartingChar :: Char -> Bool
@@ -118,6 +118,10 @@ instance Eq Name where
 instance Ord Name where
   (<=) = (<=) `on` _nameUnique
 
+-- Hashable follows Eq and Ord in only depending on the unique
+instance Hashable Name where
+  hashWithSalt s = hashWithSalt s . _nameUnique
+
 -- | A unique identifier
 newtype Unique = Unique {unUnique :: Int}
   deriving stock (Eq, Show, Ord, Lift)

diff --git a/plutus-tx-plugin/test/AsData/Budget/9.6/patternMatching.uplc.golden b/plutus-tx-plugin/test/AsData/Budget/9.6/patternMatching.uplc.golden
@@ -35,10 +35,10 @@ program
                                   (addInteger cse))
                                (addInteger cse))
                             (addInteger cse))
-                         (case cse [(\x y z w -> z)]))
-                      (case cse [(\x y z w -> x)]))
-                   (case cse [(\x y z w -> w)]))
-                (case cse [(\x y z w -> y)]))
+                         (case cse [(\x y z w -> w)]))
+                      (case cse [(\x y z w -> y)]))
+                   (case cse [(\x y z w -> z)]))
+                (case cse [(\x y z w -> x)]))
              (\x y -> addInteger x y))
           (\x y ->
              force ifThenElse